-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Fixed dev_deploy
to use registrar account to create top-level accounts (nearcore 1.37.0+ forbidden to create top-level accounts by non-registrar accounts)
#360
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fospring
force-pushed
the
issues-354/dev_deploy_after_1.37.0
branch
2 times, most recently
from
June 7, 2024 01:59
8b0db8f
to
7646b15
Compare
@frol pls take a look |
frol
reviewed
Jun 11, 2024
frol
reviewed
Jun 11, 2024
fospring
force-pushed
the
issues-354/dev_deploy_after_1.37.0
branch
from
June 11, 2024 15:56
0768dd4
to
5f5896b
Compare
frol
requested changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good. Please, address the comments and fix CI and we are good to go
fospring
force-pushed
the
issues-354/dev_deploy_after_1.37.0
branch
from
June 23, 2024 17:58
65604da
to
35281bb
Compare
fospring
force-pushed
the
issues-354/dev_deploy_after_1.37.0
branch
from
June 23, 2024 18:01
35281bb
to
563f333
Compare
fospring
force-pushed
the
issues-354/dev_deploy_after_1.37.0
branch
from
June 23, 2024 18:06
7f15bc4
to
480c1e8
Compare
frol
approved these changes
Jun 25, 2024
frol
changed the title
feat-issues-354: dev_deploy after 1.37.0
feat: Fixed Jun 25, 2024
dev_deploy
to use registrar account to create top-level accounts (nearcore 1.37.0+ forbidden to create top-level accounts by non-registrar accounts)
frol
force-pushed
the
issues-354/dev_deploy_after_1.37.0
branch
from
June 25, 2024 17:18
ba815bd
to
cadb911
Compare
This was referenced Jun 25, 2024
Merged
frol
added a commit
that referenced
this pull request
Jun 26, 2024
## 🤖 New release * `near-workspaces`: 0.10.0 -> 0.10.1 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.10.1](near-workspaces-v0.10.0...near-workspaces-v0.10.1) - 2024-06-26 ### Added - Exposes status RPC API method ([#308](#308)) - Fixed `dev_deploy` to use registrar account to create top-level accounts (nearcore 1.37.0+ forbidden to create top-level accounts by non-registrar accounts) ([#360](#360)) - Re-exported near-abi-client ([#303](#303)) ### Other - a way to get account with more than 100 near on sandbox ([#351](#351)) - Updated cargo-near to "0.5.2" ([#347](#347)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix issue: #354